diff options
| author | Jay Foad <jay.foad@gmail.com> | 2011-01-11 15:07:38 +0000 |
|---|---|---|
| committer | Jay Foad <jay.foad@gmail.com> | 2011-01-11 15:07:38 +0000 |
| commit | 67c619ba3eae68dcdb3f9340d82b33173aa0c256 (patch) | |
| tree | 3c0745fca275d5e4e31f1da2a5a84553fe69bd4a /lib/Bitcode/Reader | |
| parent | 65fdded3197461232d8428af7ddd0107e4a9f946 (diff) | |
| download | llvm-67c619ba3eae68dcdb3f9340d82b33173aa0c256.tar.gz llvm-67c619ba3eae68dcdb3f9340d82b33173aa0c256.tar.bz2 llvm-67c619ba3eae68dcdb3f9340d82b33173aa0c256.tar.xz | |
FixedNumOperandTraits and VariadicOperandTraits assumed that, given a
"this" pointer for any subclass of User, you could static_cast it to
User* and then reinterpret_cast that to Use* to get the end of the
operand list. This isn't a safe assumption in general, because the
static_cast might adjust the "this" pointer. Fixed by having these
OperandTraits classes take an extra template parameter, which is the
subclass of User. This is groundwork for PR889.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@123235 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Bitcode/Reader')
| -rw-r--r-- | lib/Bitcode/Reader/BitcodeReader.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/Bitcode/Reader/BitcodeReader.cpp b/lib/Bitcode/Reader/BitcodeReader.cpp index 7a71b267ea..adcad74989 100644 --- a/lib/Bitcode/Reader/BitcodeReader.cpp +++ b/lib/Bitcode/Reader/BitcodeReader.cpp @@ -162,7 +162,8 @@ namespace { // FIXME: can we inherit this from ConstantExpr? template <> -struct OperandTraits<ConstantPlaceHolder> : public FixedNumOperandTraits<1> { +struct OperandTraits<ConstantPlaceHolder> : + public FixedNumOperandTraits<ConstantPlaceHolder, 1> { }; } |