diff options
| author | David Blaikie <dblaikie@gmail.com> | 2014-04-28 22:41:39 +0000 |
|---|---|---|
| committer | David Blaikie <dblaikie@gmail.com> | 2014-04-28 22:41:39 +0000 |
| commit | d200f074f518bc5a5192a887add1dc0b7816cb8a (patch) | |
| tree | 391b8a6fd38bac649f649c20a8bbad1f10e92c13 /lib/CodeGen/AsmPrinter/DIE.h | |
| parent | dc9a4f73917515d46c858fda38a88e1392060993 (diff) | |
| download | llvm-d200f074f518bc5a5192a887add1dc0b7816cb8a.tar.gz llvm-d200f074f518bc5a5192a887add1dc0b7816cb8a.tar.bz2 llvm-d200f074f518bc5a5192a887add1dc0b7816cb8a.tar.xz | |
DIE: Document some learnings about why the world isn't perfect.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@207458 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/CodeGen/AsmPrinter/DIE.h')
| -rw-r--r-- | lib/CodeGen/AsmPrinter/DIE.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/lib/CodeGen/AsmPrinter/DIE.h b/lib/CodeGen/AsmPrinter/DIE.h index 1a1c080c32..ef05f17078 100644 --- a/lib/CodeGen/AsmPrinter/DIE.h +++ b/lib/CodeGen/AsmPrinter/DIE.h @@ -124,6 +124,12 @@ protected: /// Children DIEs. /// + // This can't be a vector<DIE> because pointer validity is requirent for the + // Parent pointer and DIEEntry. + // It can't be a list<DIE> because some clients need pointer validity before + // the object has been added to any child list + // (eg: DwarfUnit::constructVariableDIE). These aren't insurmountable, but may + // be more convoluted than beneficial. std::vector<std::unique_ptr<DIE>> Children; DIE *Parent; |