diff options
author | Devang Patel <dpatel@apple.com> | 2011-12-08 21:33:23 +0000 |
---|---|---|
committer | Devang Patel <dpatel@apple.com> | 2011-12-08 21:33:23 +0000 |
commit | cf405ba7a6e9448b753d9b72940059530c70ea90 (patch) | |
tree | 8550d846f9375f057ecfe3aecc1d09b9702b6043 /lib/CodeGen/MachineSink.cpp | |
parent | 7a7194b5294661809ab37270c8ee5e94f8cdee18 (diff) | |
download | llvm-cf405ba7a6e9448b753d9b72940059530c70ea90.tar.gz llvm-cf405ba7a6e9448b753d9b72940059530c70ea90.tar.bz2 llvm-cf405ba7a6e9448b753d9b72940059530c70ea90.tar.xz |
Filter "sink to" candidate blocks sooner. This avoids unnecessary computation to determine whether the block dominates all uses or not.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@146184 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/CodeGen/MachineSink.cpp')
-rw-r--r-- | lib/CodeGen/MachineSink.cpp | 24 |
1 files changed, 13 insertions, 11 deletions
diff --git a/lib/CodeGen/MachineSink.cpp b/lib/CodeGen/MachineSink.cpp index 8a34237789..0d14b63b63 100644 --- a/lib/CodeGen/MachineSink.cpp +++ b/lib/CodeGen/MachineSink.cpp @@ -499,10 +499,21 @@ bool MachineSinking::SinkInstruction(MachineInstr *MI, bool &SawStore) { // we should sink to. for (MachineBasicBlock::succ_iterator SI = ParentBlock->succ_begin(), E = ParentBlock->succ_end(); SI != E; ++SI) { + MachineBasicBlock *SuccBlock = *SI; + // It is not possible to sink an instruction into its own block. This can + // happen with loops. + if (ParentBlock == SuccBlock) + continue; + + // It's not safe to sink instructions to EH landing pad. Control flow into + // landing pad is implicitly defined. + if (SuccBlock->isLandingPad()) + continue; + bool LocalUse = false; - if (AllUsesDominatedByBlock(Reg, *SI, ParentBlock, + if (AllUsesDominatedByBlock(Reg, SuccBlock, ParentBlock, BreakPHIEdge, LocalUse)) { - SuccToSinkTo = *SI; + SuccToSinkTo = SuccBlock; break; } if (LocalUse) @@ -520,15 +531,6 @@ bool MachineSinking::SinkInstruction(MachineInstr *MI, bool &SawStore) { if (SuccToSinkTo == 0) return false; - // It's not safe to sink instructions to EH landing pad. Control flow into - // landing pad is implicitly defined. - if (SuccToSinkTo->isLandingPad()) - return false; - - // It is not possible to sink an instruction into its own block. This can - // happen with loops. - if (MI->getParent() == SuccToSinkTo) - return false; // If the instruction to move defines a dead physical register which is live // when leaving the basic block, don't move it because it could turn into a |