diff options
| author | Duncan Sands <baldrick@free.fr> | 2010-11-18 20:05:18 +0000 |
|---|---|---|
| committer | Duncan Sands <baldrick@free.fr> | 2010-11-18 20:05:18 +0000 |
| commit | dcfd3a798ffbd5e02d4892eeef562c9124598844 (patch) | |
| tree | 7a9a91a019d76abf51392d3906a62b7a3ec74922 /lib/CodeGen | |
| parent | d0c6f3dafd7c3e9137d4e6415014c94137fcd3fc (diff) | |
| download | llvm-dcfd3a798ffbd5e02d4892eeef562c9124598844.tar.gz llvm-dcfd3a798ffbd5e02d4892eeef562c9124598844.tar.bz2 llvm-dcfd3a798ffbd5e02d4892eeef562c9124598844.tar.xz | |
The DAGCombiner was threading select over pairs of extending loads even
if the extension types were not the same. The result was that if you
fed a select with sext and zext loads, as in the testcase, then it
would get turned into a zext (or sext) of the select, which is wrong
in the cases when it should have been an sext (resp. zext). Reported
and diagnosed by Sebastien Deldon.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@119728 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/CodeGen')
| -rw-r--r-- | lib/CodeGen/SelectionDAG/DAGCombiner.cpp | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/lib/CodeGen/SelectionDAG/DAGCombiner.cpp index 1a0f503378..53b449309c 100644 --- a/lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ b/lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -6658,6 +6658,11 @@ bool DAGCombiner::SimplifySelectOps(SDNode *TheSelect, SDValue LHS, LLD->isVolatile() || RLD->isVolatile() || // If this is an EXTLOAD, the VT's must match. LLD->getMemoryVT() != RLD->getMemoryVT() || + // If this is an EXTLOAD, the kind of extension must match. + (LLD->getExtensionType() != RLD->getExtensionType() && + // The only exception is if one of the extensions is anyext. + LLD->getExtensionType() != ISD::EXTLOAD && + RLD->getExtensionType() != ISD::EXTLOAD) || // FIXME: this discards src value information. This is // over-conservative. It would be beneficial to be able to remember // both potential memory locations. Since we are discarding |