diff options
author | Yuchen Wu <yuchenericwu@hotmail.com> | 2013-11-14 00:38:41 +0000 |
---|---|---|
committer | Yuchen Wu <yuchenericwu@hotmail.com> | 2013-11-14 00:38:41 +0000 |
commit | 4bd0224887a8de1434186cad2f618c18dea06c0b (patch) | |
tree | 0672bcc76b8b74756d6221b2a6e37ee587f22da1 /lib/IR/GCOV.cpp | |
parent | 131a764e0e7abc90b322fd568e042d3c5a0633af (diff) | |
download | llvm-4bd0224887a8de1434186cad2f618c18dea06c0b.tar.gz llvm-4bd0224887a8de1434186cad2f618c18dea06c0b.tar.bz2 llvm-4bd0224887a8de1434186cad2f618c18dea06c0b.tar.xz |
llvm-cov: Slightly improved error checking.
- readInt() should check all 4 bytes can be read, not just 1.
- In the event of false data in the gcno file, it was possible to index
into a non-existent index of SmallVector, causing assertion error.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@194639 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/IR/GCOV.cpp')
-rw-r--r-- | lib/IR/GCOV.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/lib/IR/GCOV.cpp b/lib/IR/GCOV.cpp index 65ed3a5a84..a91e88c4e0 100644 --- a/lib/IR/GCOV.cpp +++ b/lib/IR/GCOV.cpp @@ -135,6 +135,10 @@ bool GCOVFunction::read(GCOVBuffer &Buff, GCOV::GCOVFormat Format) { // This for loop adds the counts for each block. A second nested loop is // required to combine the edge counts that are contained in the GCDA file. for (uint32_t Line = 0; Count > 0; ++Line) { + if (Line >= Blocks.size()) { + errs() << "Unexpected number of edges.\n"; + return false; + } GCOVBlock &Block = *Blocks[Line]; for (size_t Edge = 0, End = Block.getNumEdges(); Edge < End; ++Edge) { if (Count == 0) { |