diff options
author | Rafael Espindola <rafael.espindola@gmail.com> | 2014-06-06 01:20:28 +0000 |
---|---|---|
committer | Rafael Espindola <rafael.espindola@gmail.com> | 2014-06-06 01:20:28 +0000 |
commit | 6fd1b8ee48de8deeabc89f70c37b88957b562ba0 (patch) | |
tree | 538d7a72d829478809c119d62de83e8ed7993f6e /lib/IR | |
parent | bbd34136f344e88ec8a0b148da908c01a1c3d910 (diff) | |
download | llvm-6fd1b8ee48de8deeabc89f70c37b88957b562ba0.tar.gz llvm-6fd1b8ee48de8deeabc89f70c37b88957b562ba0.tar.bz2 llvm-6fd1b8ee48de8deeabc89f70c37b88957b562ba0.tar.xz |
Allow aliases to be unnamed_addr.
Alias with unnamed_addr were in a strange state. It is stored in GlobalValue,
the language reference talks about "unnamed_addr aliases" but the verifier
was rejecting them.
It seems natural to allow unnamed_addr in aliases:
* It is a property of how it is accessed, not of the data itself.
* It is perfectly possible to write code that depends on the address
of an alias.
This patch then makes unname_addr legal for aliases. One side effect is that
the syntax changes for a corner case: In globals, unnamed_addr is now printed
before the address space.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@210302 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/IR')
-rw-r--r-- | lib/IR/AsmWriter.cpp | 5 | ||||
-rw-r--r-- | lib/IR/Verifier.cpp | 1 |
2 files changed, 4 insertions, 2 deletions
diff --git a/lib/IR/AsmWriter.cpp b/lib/IR/AsmWriter.cpp index 14467137aa..fc73a61f9f 100644 --- a/lib/IR/AsmWriter.cpp +++ b/lib/IR/AsmWriter.cpp @@ -1451,10 +1451,11 @@ void AssemblyWriter::printGlobal(const GlobalVariable *GV) { PrintVisibility(GV->getVisibility(), Out); PrintDLLStorageClass(GV->getDLLStorageClass(), Out); PrintThreadLocalModel(GV->getThreadLocalMode(), Out); + if (GV->hasUnnamedAddr()) + Out << "unnamed_addr "; if (unsigned AddressSpace = GV->getType()->getAddressSpace()) Out << "addrspace(" << AddressSpace << ") "; - if (GV->hasUnnamedAddr()) Out << "unnamed_addr "; if (GV->isExternallyInitialized()) Out << "externally_initialized "; Out << (GV->isConstant() ? "constant " : "global "); TypePrinter.print(GV->getType()->getElementType(), Out); @@ -1489,6 +1490,8 @@ void AssemblyWriter::printAlias(const GlobalAlias *GA) { PrintVisibility(GA->getVisibility(), Out); PrintDLLStorageClass(GA->getDLLStorageClass(), Out); PrintThreadLocalModel(GA->getThreadLocalMode(), Out); + if (GA->hasUnnamedAddr()) + Out << "unnamed_addr "; Out << "alias "; diff --git a/lib/IR/Verifier.cpp b/lib/IR/Verifier.cpp index 46beb13622..b66bd06401 100644 --- a/lib/IR/Verifier.cpp +++ b/lib/IR/Verifier.cpp @@ -517,7 +517,6 @@ void Verifier::visitGlobalAlias(const GlobalAlias &GA) { Assert1(Aliasee, "Aliasee cannot be NULL!", &GA); Assert1(GA.getType() == Aliasee->getType(), "Alias and aliasee types should match!", &GA); - Assert1(!GA.hasUnnamedAddr(), "Alias cannot have unnamed_addr!", &GA); Assert1(isa<GlobalValue>(Aliasee) || isa<ConstantExpr>(Aliasee), "Aliasee should be either GlobalValue or ConstantExpr", &GA); |