summaryrefslogtreecommitdiff
path: root/lib/MC/MCParser/AsmParser.cpp
diff options
context:
space:
mode:
authorDavid Peixotto <dpeixott@codeaurora.org>2014-02-04 17:22:40 +0000
committerDavid Peixotto <dpeixott@codeaurora.org>2014-02-04 17:22:40 +0000
commitb92cca222898d87bbc764fa22e805adb04ef7f13 (patch)
treef094e401b602d87e38489c8cb984437ce983fb4f /lib/MC/MCParser/AsmParser.cpp
parent7d9ed1cac54f5ed4274ae2735bd06e1017a83a9b (diff)
downloadllvm-b92cca222898d87bbc764fa22e805adb04ef7f13.tar.gz
llvm-b92cca222898d87bbc764fa22e805adb04ef7f13.tar.bz2
llvm-b92cca222898d87bbc764fa22e805adb04ef7f13.tar.xz
Fix PR18345: ldr= pseudo instruction produces incorrect code when using in inline assembly
This patch fixes the ldr-pseudo implementation to work when used in inline assembly. The fix is to move arm assembler constant pools from the ARMAsmParser class to the ARMTargetStreamer class. Previously we kept the assembler generated constant pools in the ARMAsmParser object. This does not work for inline assembly because a new parser object is created for each blob of inline assembly. This patch moves the constant pools to the ARMTargetStreamer class so that the constant pool will remain alive for the entire code generation process. An ARMTargetStreamer class is now required for the arm backend. There was no existing implementation for MachO, only Asm and ELF. Instead of creating an empty MachO subclass, we decided to make the ARMTargetStreamer a non-abstract class and provide default (llvm_unreachable) implementations for the non constant-pool related methods. Differential Revision: http://llvm-reviews.chandlerc.com/D2638 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200777 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/MC/MCParser/AsmParser.cpp')
-rw-r--r--lib/MC/MCParser/AsmParser.cpp4
1 files changed, 0 insertions, 4 deletions
diff --git a/lib/MC/MCParser/AsmParser.cpp b/lib/MC/MCParser/AsmParser.cpp
index 63a00fedfa..459e126793 100644
--- a/lib/MC/MCParser/AsmParser.cpp
+++ b/lib/MC/MCParser/AsmParser.cpp
@@ -681,10 +681,6 @@ bool AsmParser::Run(bool NoInitialTextSection, bool NoFinalize) {
}
}
- // Callback to the target parser in case it needs to do anything.
- if (!HadError)
- getTargetParser().finishParse();
-
// Finalize the output stream if there are no errors and if the client wants
// us to.
if (!HadError && !NoFinalize)