diff options
author | Hans Wennborg <hans@hanshq.net> | 2013-10-16 01:20:40 +0000 |
---|---|---|
committer | Hans Wennborg <hans@hanshq.net> | 2013-10-16 01:20:40 +0000 |
commit | 508d7b7330968c48e69f0da82c66bdcc0afe6190 (patch) | |
tree | b55d6135b721f51ccb8a9db2b5c3283b5b211430 /lib/MC/MCSectionCOFF.cpp | |
parent | c7ce3e4f42219003f30382be17d966cb2dfb4e71 (diff) | |
download | llvm-508d7b7330968c48e69f0da82c66bdcc0afe6190.tar.gz llvm-508d7b7330968c48e69f0da82c66bdcc0afe6190.tar.bz2 llvm-508d7b7330968c48e69f0da82c66bdcc0afe6190.tar.xz |
MC: Better handling of tricky symbol and section names
Because of win32 mangling, we produce symbol and section names with
funny characters in them, most notably @ characters.
MC would choke on trying to parse its own assembly output. This patch addresses
that by:
- Making @ trigger quoting of symbol names
- Also quote section names in the same way
- Just parse section names like other identifiers (to allow for quotes)
- Don't assume @ signifies a symbol variant if it is in a string.
Differential Revision: http://llvm-reviews.chandlerc.com/D1945
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@192758 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/MC/MCSectionCOFF.cpp')
-rw-r--r-- | lib/MC/MCSectionCOFF.cpp | 21 |
1 files changed, 20 insertions, 1 deletions
diff --git a/lib/MC/MCSectionCOFF.cpp b/lib/MC/MCSectionCOFF.cpp index 64aa2c5c49..a8f5db095b 100644 --- a/lib/MC/MCSectionCOFF.cpp +++ b/lib/MC/MCSectionCOFF.cpp @@ -39,6 +39,22 @@ void MCSectionCOFF::setSelection(int Selection, Characteristics |= COFF::IMAGE_SCN_LNK_COMDAT; } +static bool isAcceptableSectionNameChar(char C) { + return (C >= 'a' && C <= 'z') || + (C >= 'A' && C <= 'Z') || + (C >= '0' && C <= '9') || + C == '_' || C == '$' || C == '.'; +} + +/// NameNeedsQuoting - Return true if the identifier \p Str needs quotes to be +/// syntactically correct. +static bool sectionNameNeedsQuoting(StringRef Name) { + for (unsigned i = 0, e = Name.size(); i != e; ++i) + if (!isAcceptableSectionNameChar(Name[i])) + return true; + return false; +} + void MCSectionCOFF::PrintSwitchToSection(const MCAsmInfo &MAI, raw_ostream &OS, const MCExpr *Subsection) const { @@ -49,7 +65,10 @@ void MCSectionCOFF::PrintSwitchToSection(const MCAsmInfo &MAI, return; } - OS << "\t.section\t" << getSectionName() << ",\""; + if (sectionNameNeedsQuoting(getSectionName())) + OS << "\t.section\t" << '"' << getSectionName() << '"' << ",\""; + else + OS << "\t.section\t" << getSectionName() << ",\""; if (getKind().isText()) OS << 'x'; if (getKind().isWriteable()) |