diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2014-04-03 00:19:35 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2014-04-03 00:19:35 +0000 |
| commit | 14ae43449c7038afa8dced4f5cb054b243b67d76 (patch) | |
| tree | 6659e1b190721d56eecd7009b980780252028133 /lib/Object/MachOObjectFile.cpp | |
| parent | 1498ceee9e14815f2103794980a4b4f63eee1a4c (diff) | |
| download | llvm-14ae43449c7038afa8dced4f5cb054b243b67d76.tar.gz llvm-14ae43449c7038afa8dced4f5cb054b243b67d76.tar.bz2 llvm-14ae43449c7038afa8dced4f5cb054b243b67d76.tar.xz | |
Revert "Fix a nomenclature error in llvm-nm."
This reverts commit r205479.
It turns out that nm does use addresses, it is just that every reasonable
relocatable ELF object has sections with address 0. I have no idea if those
exist in reality, but it at least it shows that llvm-nm should use the name
address.
The added test was includes an unusual .o file with non 0 section addresses. I
created it by hacking ELFObjectWriter.cpp.
Really sorry for the churn.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@205493 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Object/MachOObjectFile.cpp')
| -rw-r--r-- | lib/Object/MachOObjectFile.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/lib/Object/MachOObjectFile.cpp b/lib/Object/MachOObjectFile.cpp index df4e044e71..6955ef090a 100644 --- a/lib/Object/MachOObjectFile.cpp +++ b/lib/Object/MachOObjectFile.cpp @@ -633,8 +633,7 @@ MachOObjectFile::getSymbolSection(DataRefImpl Symb, error_code MachOObjectFile::getSymbolValue(DataRefImpl Symb, uint64_t &Val) const { - // In MachO both relocatable and non-relocatable objects have addresses. - return getSymbolAddress(Symb, Val); + report_fatal_error("getSymbolValue unimplemented in MachOObjectFile"); } void MachOObjectFile::moveSectionNext(DataRefImpl &Sec) const { |