diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2014-02-24 18:20:12 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2014-02-24 18:20:12 +0000 |
| commit | ac69459e0fe3df04788f5adcb94b1bec8b8cf8ad (patch) | |
| tree | 6260ace05d8d32042f39b42aead973d7c3ebaf9a /lib/Support/Path.cpp | |
| parent | 137342f198093f68e112cd979782fae27bbb22ab (diff) | |
| download | llvm-ac69459e0fe3df04788f5adcb94b1bec8b8cf8ad.tar.gz llvm-ac69459e0fe3df04788f5adcb94b1bec8b8cf8ad.tar.bz2 llvm-ac69459e0fe3df04788f5adcb94b1bec8b8cf8ad.tar.xz | |
Replace the F_Binary flag with a F_Text one.
After this I will set the default back to F_None. The advantage is that
before this patch forgetting to set F_Binary would corrupt a file on windows.
Forgetting to set F_Text produces one that cannot be read in notepad, which
is a better failure mode :-)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202052 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Support/Path.cpp')
| -rw-r--r-- | lib/Support/Path.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/Support/Path.cpp b/lib/Support/Path.cpp index 5b8be18db3..1bd94a76fa 100644 --- a/lib/Support/Path.cpp +++ b/lib/Support/Path.cpp @@ -201,9 +201,9 @@ retry_random_path: // Try to open + create the file. switch (Type) { case FS_File: { - if (error_code EC = sys::fs::openFileForWrite( - Twine(ResultPath.begin()), ResultFD, - sys::fs::F_RW | sys::fs::F_Excl | sys::fs::F_Binary, Mode)) { + if (error_code EC = + sys::fs::openFileForWrite(Twine(ResultPath.begin()), ResultFD, + sys::fs::F_RW | sys::fs::F_Excl, Mode)) { if (EC == errc::file_exists) goto retry_random_path; return EC; |