diff options
author | Daniel Sanders <daniel.sanders@imgtec.com> | 2014-05-08 09:29:28 +0000 |
---|---|---|
committer | Daniel Sanders <daniel.sanders@imgtec.com> | 2014-05-08 09:29:28 +0000 |
commit | 01ce4b98ced7c239bdcdd13506a52d4a0cbbbefe (patch) | |
tree | 79dffa694c6d44cd8d6f225609ed4b9e62510a8a /lib/TableGen | |
parent | f35ce2376ca361e059ad9390ce1f8467f8756bcd (diff) | |
download | llvm-01ce4b98ced7c239bdcdd13506a52d4a0cbbbefe.tar.gz llvm-01ce4b98ced7c239bdcdd13506a52d4a0cbbbefe.tar.bz2 llvm-01ce4b98ced7c239bdcdd13506a52d4a0cbbbefe.tar.xz |
Use a vector of unique_ptrs to fix a memory leak introduced in r208179.
Also removed an inaccurate comment that stated that a DenseMap was used as
storage for the ListInit*'s. It's currently using a FoldingSet.
I expect there's a better way to fix this but I haven't found it yet. FoldingSet
is incompatible with the Pool template and I'm not sure if FoldingSet can be
safely replaced with a DenseMap of computed FoldingSetID's to ListInit*'s.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@208293 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/TableGen')
-rw-r--r-- | lib/TableGen/Record.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/TableGen/Record.cpp b/lib/TableGen/Record.cpp index c17aea99f8..c553a21c26 100644 --- a/lib/TableGen/Record.cpp +++ b/lib/TableGen/Record.cpp @@ -623,9 +623,8 @@ static void ProfileListInit(FoldingSetNodeID &ID, ListInit *ListInit::get(ArrayRef<Init *> Range, RecTy *EltTy) { typedef FoldingSet<ListInit> Pool; static Pool ThePool; + static std::vector<std::unique_ptr<ListInit>> TheActualPool; - // Just use the FoldingSetNodeID to compute a hash. Use a DenseMap - // for actual storage. FoldingSetNodeID ID; ProfileListInit(ID, Range, EltTy); @@ -635,6 +634,7 @@ ListInit *ListInit::get(ArrayRef<Init *> Range, RecTy *EltTy) { ListInit *I = new ListInit(Range, EltTy); ThePool.InsertNode(I, IP); + TheActualPool.push_back(std::unique_ptr<ListInit>(I)); return I; } |