summaryrefslogtreecommitdiff
path: root/lib/Target/PowerPC/PPCAsmPrinter.cpp
diff options
context:
space:
mode:
authorHal Finkel <hfinkel@anl.gov>2012-08-29 20:22:24 +0000
committerHal Finkel <hfinkel@anl.gov>2012-08-29 20:22:24 +0000
commitbbd169b1d96e1012df9852d41b7fd00381ed9d48 (patch)
treeec4275f2ba8ab42adebbe30f4ded62b04dc96ff4 /lib/Target/PowerPC/PPCAsmPrinter.cpp
parent21b742ffce7bec3d71e09c7c6d901a756d55feb3 (diff)
downloadllvm-bbd169b1d96e1012df9852d41b7fd00381ed9d48.tar.gz
llvm-bbd169b1d96e1012df9852d41b7fd00381ed9d48.tar.bz2
llvm-bbd169b1d96e1012df9852d41b7fd00381ed9d48.tar.xz
Reserve space for the mandatory traceback fields on PPC64.
We need to reserve space for the mandatory traceback fields, though leaving them as zero is appropriate for now. Although the ABI calls for these fields to be filled in fully, no compiler on Linux currently does this, and GDB does not read these fields. GDB uses the first word of zeroes during exception handling to find the end of the function and the size field, allowing it to compute the beginning of the function. DWARF information is used for everything else. We need the extra 8 bytes of pad so the size field is found in the right place. As a comparison, GCC fills in a few of the fields -- language, number of saved registers -- but ignores the rest. IBM's proprietary OSes do make use of the full traceback table facility. Patch by Bill Schmidt. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@162854 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Target/PowerPC/PPCAsmPrinter.cpp')
-rw-r--r--lib/Target/PowerPC/PPCAsmPrinter.cpp12
1 files changed, 8 insertions, 4 deletions
diff --git a/lib/Target/PowerPC/PPCAsmPrinter.cpp b/lib/Target/PowerPC/PPCAsmPrinter.cpp
index de3241504d..1c9a23aa68 100644
--- a/lib/Target/PowerPC/PPCAsmPrinter.cpp
+++ b/lib/Target/PowerPC/PPCAsmPrinter.cpp
@@ -458,11 +458,15 @@ bool PPCLinuxAsmPrinter::doFinalization(Module &M) {
void PPCLinuxAsmPrinter::EmitFunctionBodyEnd() {
// Only the 64-bit target requires a traceback table. For now,
// we only emit the word of zeroes that GDB requires to find
- // the end of the function.
- // FIXME: Eventually we should add the eight-byte mandatory fields
- // described in the PPC64 ELF ABI.
- if (Subtarget.isPPC64())
+ // the end of the function, and zeroes for the eight-byte
+ // mandatory fields.
+ // FIXME: We should fill in the eight-byte mandatory fields as described in
+ // the PPC64 ELF ABI (this is a low-priority item because GDB does not
+ // currently make use of these fields).
+ if (Subtarget.isPPC64()) {
OutStreamer.EmitIntValue(0, 4/*size*/);
+ OutStreamer.EmitIntValue(0, 8/*size*/);
+ }
}
void PPCDarwinAsmPrinter::EmitStartOfAsmFile(Module &M) {