diff options
| author | Lang Hames <lhames@gmail.com> | 2014-02-04 19:42:47 +0000 |
|---|---|---|
| committer | Lang Hames <lhames@gmail.com> | 2014-02-04 19:42:47 +0000 |
| commit | 051faa2cfa63b5add668592c9e6cc240a876cdb9 (patch) | |
| tree | 1ae6cd16f84d0535996bd7346365b8c02c7766ec /lib/Target/X86 | |
| parent | 483727da487c1cb97c6b23ce6eea37886a0df0e1 (diff) | |
| download | llvm-051faa2cfa63b5add668592c9e6cc240a876cdb9.tar.gz llvm-051faa2cfa63b5add668592c9e6cc240a876cdb9.tar.bz2 llvm-051faa2cfa63b5add668592c9e6cc240a876cdb9.tar.xz | |
[X86] Only 213 FMA3 variants should be marked commutable.
Commuting the 231 and 132 variants would swap addends and
multiplicands/multipliers, which isn't valid.
I'm still trying to reduce a decent test case for this.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200792 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Target/X86')
| -rw-r--r-- | lib/Target/X86/X86InstrFMA.td | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/lib/Target/X86/X86InstrFMA.td b/lib/Target/X86/X86InstrFMA.td index 033033ca69..d994f5f3ec 100644 --- a/lib/Target/X86/X86InstrFMA.td +++ b/lib/Target/X86/X86InstrFMA.td @@ -20,7 +20,7 @@ multiclass fma3p_rm<bits<8> opc, string OpcodeStr, PatFrag MemFrag128, PatFrag MemFrag256, ValueType OpVT128, ValueType OpVT256, SDPatternOperator Op = null_frag> { - let isCommutable = 1, usesCustomInserter = 1 in + let usesCustomInserter = 1 in def r : FMA3<opc, MRMSrcReg, (outs VR128:$dst), (ins VR128:$src1, VR128:$src2, VR128:$src3), !strconcat(OpcodeStr, @@ -36,7 +36,7 @@ multiclass fma3p_rm<bits<8> opc, string OpcodeStr, [(set VR128:$dst, (OpVT128 (Op VR128:$src2, VR128:$src1, (MemFrag128 addr:$src3))))]>; - let isCommutable = 1, usesCustomInserter = 1 in + let usesCustomInserter = 1 in def rY : FMA3<opc, MRMSrcReg, (outs VR256:$dst), (ins VR256:$src1, VR256:$src2, VR256:$src3), !strconcat(OpcodeStr, @@ -59,6 +59,7 @@ multiclass fma3p_forms<bits<8> opc132, bits<8> opc213, bits<8> opc231, string OpcodeStr, string PackTy, PatFrag MemFrag128, PatFrag MemFrag256, SDNode Op, ValueType OpTy128, ValueType OpTy256> { + let isCommutable = 1 in defm r213 : fma3p_rm<opc213, !strconcat(OpcodeStr, "213", PackTy), MemFrag128, MemFrag256, OpTy128, OpTy256, Op>; @@ -118,7 +119,7 @@ let Constraints = "$src1 = $dst" in { multiclass fma3s_rm<bits<8> opc, string OpcodeStr, X86MemOperand x86memop, RegisterClass RC, ValueType OpVT, PatFrag mem_frag, SDPatternOperator OpNode = null_frag> { - let isCommutable = 1, usesCustomInserter = 1 in + let usesCustomInserter = 1 in def r : FMA3<opc, MRMSrcReg, (outs RC:$dst), (ins RC:$src1, RC:$src2, RC:$src3), !strconcat(OpcodeStr, @@ -149,6 +150,7 @@ let neverHasSideEffects = 1 in { x86memop, RC, OpVT, mem_frag>; } +let isCommutable = 1 in defm r213 : fma3s_rm<opc213, !strconcat(OpStr, "213", PackTy), x86memop, RC, OpVT, mem_frag, OpNode>; } |