diff options
| author | David Majnemer <david.majnemer@gmail.com> | 2014-06-26 03:02:19 +0000 |
|---|---|---|
| committer | David Majnemer <david.majnemer@gmail.com> | 2014-06-26 03:02:19 +0000 |
| commit | 29640bcb7d7738e7e611b0150b6ac57e2d2b723f (patch) | |
| tree | 81c70c56439220a7417280abe3657ed676384430 /lib/Transforms/IPO | |
| parent | b0f5a0e7e7fb08f6ab97603ef68b4837f62755a0 (diff) | |
| download | llvm-29640bcb7d7738e7e611b0150b6ac57e2d2b723f.tar.gz llvm-29640bcb7d7738e7e611b0150b6ac57e2d2b723f.tar.bz2 llvm-29640bcb7d7738e7e611b0150b6ac57e2d2b723f.tar.xz | |
GlobalOpt: Don't optimize thread_local for initializers
Folding a reference to a thread_local variable into another global
variable's initializer is very problematic, there is no relocation that
exists to represent such an access.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@211762 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Transforms/IPO')
| -rw-r--r-- | lib/Transforms/IPO/GlobalOpt.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/Transforms/IPO/GlobalOpt.cpp b/lib/Transforms/IPO/GlobalOpt.cpp index 75c1878f3f..36c04f092b 100644 --- a/lib/Transforms/IPO/GlobalOpt.cpp +++ b/lib/Transforms/IPO/GlobalOpt.cpp @@ -1980,9 +1980,10 @@ isSimpleEnoughValueToCommit(Constant *C, static bool isSimpleEnoughValueToCommitHelper(Constant *C, SmallPtrSet<Constant*, 8> &SimpleConstants, const DataLayout *DL) { - // Simple global addresses are supported, do not allow dllimport globals. + // Simple global addresses are supported, do not allow dllimport or + // thread-local globals. if (auto *GV = dyn_cast<GlobalValue>(C)) - return !GV->hasDLLImportStorageClass(); + return !GV->hasDLLImportStorageClass() && !GV->isThreadLocal(); // Simple integer, undef, constant aggregate zero, etc are all supported. if (C->getNumOperands() == 0 || isa<BlockAddress>(C)) |