diff options
author | Andrew Trick <atrick@apple.com> | 2014-03-25 02:18:47 +0000 |
---|---|---|
committer | Andrew Trick <atrick@apple.com> | 2014-03-25 02:18:47 +0000 |
commit | f5bf687cf7a9941b6d795b9db99a78c64e233b74 (patch) | |
tree | 79ebe96b11640ac7d66fabbb12753434eabe9145 /lib/Transforms/Vectorize/SLPVectorizer.cpp | |
parent | b13d54f5880b2dafadd89182ee9adaff11fa9cf3 (diff) | |
download | llvm-f5bf687cf7a9941b6d795b9db99a78c64e233b74.tar.gz llvm-f5bf687cf7a9941b6d795b9db99a78c64e233b74.tar.bz2 llvm-f5bf687cf7a9941b6d795b9db99a78c64e233b74.tar.xz |
SLP vectorizer: Don't hoist vector extracts of phis.
Extracts coming from phis were being hoisted, while all others were
sunk to their uses. This was inconsistent and didn't seem to serve a
purpose. Changing all extracts to be sunk to uses is a prerequisite
for adding block frequency to the SLP vectorizer's cost model.
I benchmarked the change in isolation (without block frequency). I
only saw noise on x86 and some potentially significant improvements on
ARM. No major regressions is good enough for me.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204699 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Transforms/Vectorize/SLPVectorizer.cpp')
-rw-r--r-- | lib/Transforms/Vectorize/SLPVectorizer.cpp | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/lib/Transforms/Vectorize/SLPVectorizer.cpp b/lib/Transforms/Vectorize/SLPVectorizer.cpp index bd9c5c75cc..97b34f476e 100644 --- a/lib/Transforms/Vectorize/SLPVectorizer.cpp +++ b/lib/Transforms/Vectorize/SLPVectorizer.cpp @@ -1690,12 +1690,7 @@ Value *BoUpSLP::vectorizeTree() { Value *Lane = Builder.getInt32(it->Lane); // Generate extracts for out-of-tree users. // Find the insertion point for the extractelement lane. - if (PHINode *PN = dyn_cast<PHINode>(Vec)) { - Builder.SetInsertPoint(PN->getParent()->getFirstInsertionPt()); - Value *Ex = Builder.CreateExtractElement(Vec, Lane); - CSEBlocks.insert(PN->getParent()); - User->replaceUsesOfWith(Scalar, Ex); - } else if (isa<Instruction>(Vec)){ + if (isa<Instruction>(Vec)){ if (PHINode *PH = dyn_cast<PHINode>(User)) { for (int i = 0, e = PH->getNumIncomingValues(); i != e; ++i) { if (PH->getIncomingValue(i) == Scalar) { |