diff options
author | Rafael Espindola <rafael.espindola@gmail.com> | 2014-02-06 00:54:53 +0000 |
---|---|---|
committer | Rafael Espindola <rafael.espindola@gmail.com> | 2014-02-06 00:54:53 +0000 |
commit | b03e2929d3652b7547c1935772b4b830917a38bd (patch) | |
tree | d25234a6f99b1574f24399e49e9a628ffec83981 /lib | |
parent | 2684ddd72e6274be60129d5510d9d5073463d0a4 (diff) | |
download | llvm-b03e2929d3652b7547c1935772b4b830917a38bd.tar.gz llvm-b03e2929d3652b7547c1935772b4b830917a38bd.tar.bz2 llvm-b03e2929d3652b7547c1935772b4b830917a38bd.tar.xz |
doesSectionRequireSymbols is meaningless on ELF, remove.
This is a nop. doesSectionRequireSymbols is only used from
isSymbolLinkerVisible. isSymbolLinkerVisible only use from ELF was in
if (!Asm.isSymbolLinkerVisible(Symbol) && !Symbol.isUndefined())
return false;
if (Symbol.isTemporary())
return false;
If the symbol is a temporary this code returns false and it is irrelevant if
we take the first if or not. If the symbol is not a temporary,
Asm.isSymbolLinkerVisible returns true without ever calling
doesSectionRequireSymbols.
This was an horrible leftover from when support for ELF was first added.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200894 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib')
-rw-r--r-- | lib/MC/ELFObjectWriter.cpp | 3 | ||||
-rw-r--r-- | lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp | 5 |
2 files changed, 0 insertions, 8 deletions
diff --git a/lib/MC/ELFObjectWriter.cpp b/lib/MC/ELFObjectWriter.cpp index f6dbfced54..8b2ab02bec 100644 --- a/lib/MC/ELFObjectWriter.cpp +++ b/lib/MC/ELFObjectWriter.cpp @@ -848,9 +848,6 @@ bool ELFObjectWriter::isInSymtab(const MCAssembler &Asm, if (!Symbol.isVariable() && Symbol.isUndefined() && !IsGlobal) return false; - if (!Asm.isSymbolLinkerVisible(Symbol) && !Symbol.isUndefined()) - return false; - if (Symbol.isTemporary()) return false; diff --git a/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp b/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp index dfd8a658bd..1260208f40 100644 --- a/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp +++ b/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp @@ -350,11 +350,6 @@ public: : X86AsmBackend(T, CPU), OSABI(_OSABI) { HasReliableSymbolDifference = true; } - - virtual bool doesSectionRequireSymbols(const MCSection &Section) const { - const MCSectionELF &ES = static_cast<const MCSectionELF&>(Section); - return ES.getFlags() & ELF::SHF_MERGE; - } }; class ELFX86_32AsmBackend : public ELFX86AsmBackend { |