diff options
| author | Reid Kleckner <reid@kleckner.net> | 2013-12-03 19:13:18 +0000 |
|---|---|---|
| committer | Reid Kleckner <reid@kleckner.net> | 2013-12-03 19:13:18 +0000 |
| commit | ca3da883b86530bc805370fadd23976b81f30638 (patch) | |
| tree | 29dc4e07944cb78d99cde75e43749d1d0283a861 /lib | |
| parent | 2575bc901b0a1cf1f13ff8609ca7a47a3f21ac29 (diff) | |
| download | llvm-ca3da883b86530bc805370fadd23976b81f30638.tar.gz llvm-ca3da883b86530bc805370fadd23976b81f30638.tar.bz2 llvm-ca3da883b86530bc805370fadd23976b81f30638.tar.xz | |
Return true on success in cl::ExpandResponseFiles
This fixes a logic bug pointed out by Juraj Ivancic.
No behavior change because none of the in-tree clients of
cl::ExpandResponseFiles check the return value. In this case, the
@prefixed arguments are left in the command line. Downstream command
line processing has the opportunity to emit errors about it, so this
isn't that bad.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@196306 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/Support/CommandLine.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/Support/CommandLine.cpp b/lib/Support/CommandLine.cpp index 44a88d81e3..9acaa08bbc 100644 --- a/lib/Support/CommandLine.cpp +++ b/lib/Support/CommandLine.cpp @@ -634,7 +634,7 @@ static bool ExpandResponseFile(const char *FName, StringSaver &Saver, bool cl::ExpandResponseFiles(StringSaver &Saver, TokenizerCallback Tokenizer, SmallVectorImpl<const char *> &Argv) { unsigned RspFiles = 0; - bool AllExpanded = false; + bool AllExpanded = true; // Don't cache Argv.size() because it can change. for (unsigned I = 0; I != Argv.size(); ) { |