diff options
author | David Blaikie <dblaikie@gmail.com> | 2013-08-14 22:23:05 +0000 |
---|---|---|
committer | David Blaikie <dblaikie@gmail.com> | 2013-08-14 22:23:05 +0000 |
commit | cbb5c73942b62e693d9233907720138dd4f40f26 (patch) | |
tree | 18b1aa0b75d08e498db4ebb65e8e70754dee3195 /lib | |
parent | 67ca7b1bb07e331981e700cc4cc5944f68a9e256 (diff) | |
download | llvm-cbb5c73942b62e693d9233907720138dd4f40f26.tar.gz llvm-cbb5c73942b62e693d9233907720138dd4f40f26.tar.bz2 llvm-cbb5c73942b62e693d9233907720138dd4f40f26.tar.xz |
DebugInfo: Prefer references over pointers, pass by const reference for a type that will grow in the future
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@188422 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib')
-rw-r--r-- | lib/CodeGen/AsmPrinter/DIEHash.cpp | 10 | ||||
-rw-r--r-- | lib/CodeGen/AsmPrinter/DIEHash.h | 4 |
2 files changed, 7 insertions, 7 deletions
diff --git a/lib/CodeGen/AsmPrinter/DIEHash.cpp b/lib/CodeGen/AsmPrinter/DIEHash.cpp index e116611673..f0ab38c3d4 100644 --- a/lib/CodeGen/AsmPrinter/DIEHash.cpp +++ b/lib/CodeGen/AsmPrinter/DIEHash.cpp @@ -103,13 +103,13 @@ void DIEHash::addParentContext(DIE *Parent) { } // Collect all of the attributes for a particular DIE in single structure. -void DIEHash::collectAttributes(DIE *Die, DIEAttrs *Attrs) { +void DIEHash::collectAttributes(DIE *Die, DIEAttrs &Attrs) { const SmallVectorImpl<DIEValue *> &Values = Die->getValues(); const DIEAbbrev &Abbrevs = Die->getAbbrev(); #define COLLECT_ATTR(NAME) \ - Attrs->NAME.Val = Values[i]; \ - Attrs->NAME.Desc = &Abbrevs.getData()[i]; + Attrs.NAME.Val = Values[i]; \ + Attrs.NAME.Desc = &Abbrevs.getData()[i]; for (size_t i = 0, e = Values.size(); i != e; ++i) { DEBUG(dbgs() << "Attribute: " @@ -150,7 +150,7 @@ void DIEHash::hashAttribute(AttrEntry Attr) { // Go through the attributes from \param Attrs in the order specified in 7.27.4 // and hash them. -void DIEHash::hashAttributes(DIEAttrs Attrs) { +void DIEHash::hashAttributes(const DIEAttrs &Attrs) { #define ADD_ATTR(ATTR) \ { \ if (ATTR.Val != 0) \ @@ -165,7 +165,7 @@ void DIEHash::hashAttributes(DIEAttrs Attrs) { void DIEHash::addAttributes(DIE *Die) { DIEAttrs Attrs; memset(&Attrs, 0, sizeof(Attrs)); - collectAttributes(Die, &Attrs); + collectAttributes(Die, Attrs); hashAttributes(Attrs); } diff --git a/lib/CodeGen/AsmPrinter/DIEHash.h b/lib/CodeGen/AsmPrinter/DIEHash.h index 0c7d6e25d5..f53529c54f 100644 --- a/lib/CodeGen/AsmPrinter/DIEHash.h +++ b/lib/CodeGen/AsmPrinter/DIEHash.h @@ -59,10 +59,10 @@ private: /// \brief Collects the attributes of DIE \param Die into the \param Attrs /// structure. - void collectAttributes(DIE *Die, DIEAttrs *Attrs); + void collectAttributes(DIE *Die, DIEAttrs &Attrs); /// \brief Hashes the attributes in \param Attrs in order. - void hashAttributes(DIEAttrs Attrs); + void hashAttributes(const DIEAttrs &Attrs); /// \brief Hashes an individual attribute. void hashAttribute(AttrEntry Attr); |