diff options
| author | Tim Northover <tnorthover@apple.com> | 2014-05-30 10:09:59 +0000 |
|---|---|---|
| committer | Tim Northover <tnorthover@apple.com> | 2014-05-30 10:09:59 +0000 |
| commit | d0dbe02fd26d47ed32c9e04a2a0385b26a49f4ed (patch) | |
| tree | 9ca25621a85c9af7e635fcebf3774ce33b6da7ae /test/CodeGen/Thumb2/2009-08-01-WrongLDRBOpc.ll | |
| parent | 7be505ae8877d99d761da08952afbe74bacdae9e (diff) | |
| download | llvm-d0dbe02fd26d47ed32c9e04a2a0385b26a49f4ed.tar.gz llvm-d0dbe02fd26d47ed32c9e04a2a0385b26a49f4ed.tar.bz2 llvm-d0dbe02fd26d47ed32c9e04a2a0385b26a49f4ed.tar.xz | |
ARM & AArch64: make use of common cmpxchg idioms after expansion
The C and C++ semantics for compare_exchange require it to return a bool
indicating success. This gets mapped to LLVM IR which follows each cmpxchg with
an icmp of the value loaded against the desired value.
When lowered to ldxr/stxr loops, this extra comparison is redundant: its
results are implicit in the control-flow of the function.
This commit makes two changes: it replaces that icmp with appropriate PHI
nodes, and then makes sure earlyCSE is called after expansion to actually make
use of the opportunities revealed.
I've also added -{arm,aarch64}-enable-atomic-tidy options, so that
existing fragile tests aren't perturbed too much by the change. Many
of them either rely on undef/unreachable too pervasively to be
restored to something well-defined (particularly while making sure
they test the same obscure assert from many years ago), or depend on a
particular CFG shape, which is disrupted by SimplifyCFG.
rdar://problem/16227836
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@209883 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/CodeGen/Thumb2/2009-08-01-WrongLDRBOpc.ll')
| -rw-r--r-- | test/CodeGen/Thumb2/2009-08-01-WrongLDRBOpc.ll | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/CodeGen/Thumb2/2009-08-01-WrongLDRBOpc.ll b/test/CodeGen/Thumb2/2009-08-01-WrongLDRBOpc.ll index e014453145..09e0ed1ead 100644 --- a/test/CodeGen/Thumb2/2009-08-01-WrongLDRBOpc.ll +++ b/test/CodeGen/Thumb2/2009-08-01-WrongLDRBOpc.ll @@ -1,4 +1,4 @@ -; RUN: llc < %s -mtriple=thumbv7-apple-darwin9 -mcpu=cortex-a8 -relocation-model=pic -disable-fp-elim | FileCheck %s +; RUN: llc < %s -mtriple=thumbv7-apple-darwin9 -mcpu=cortex-a8 -relocation-model=pic -disable-fp-elim -arm-atomic-cfg-tidy=0 | FileCheck %s @csize = external global [100 x [20 x [4 x i8]]] ; <[100 x [20 x [4 x i8]]]*> [#uses=1] @vsize = external global [100 x [20 x [4 x i8]]] ; <[100 x [20 x [4 x i8]]]*> [#uses=1] |