diff options
| author | Lang Hames <lhames@gmail.com> | 2013-10-28 20:51:11 +0000 |
|---|---|---|
| committer | Lang Hames <lhames@gmail.com> | 2013-10-28 20:51:11 +0000 |
| commit | 3d478aee8e2480661cb0d98b10da8ad2ebf59fcf (patch) | |
| tree | f5bc89bdef20e71120fcbe814e349b21eaaccae3 /test/MC | |
| parent | 164bd156fc92dc738e5f8dce5da263e1d17211c4 (diff) | |
| download | llvm-3d478aee8e2480661cb0d98b10da8ad2ebf59fcf.tar.gz llvm-3d478aee8e2480661cb0d98b10da8ad2ebf59fcf.tar.bz2 llvm-3d478aee8e2480661cb0d98b10da8ad2ebf59fcf.tar.xz | |
Return early from getUnconditionalBranchTargetOpValue if the branch target is
an MCExpr, in order to avoid writing an encoded zero value in the immediate
field.
When getUnconditionalBranchTargetOpValue is called with an MCExpr target, we
don't know what the final immediate field value should be. We shouldn't
explicitly set the immediate field to an encoded zero value as zero is encoded
with a non-zero bit pattern. This leads to bits being set that pollute the
final immediate value. The nature of the encoding is such that the polluted
bits only affect very large immediate values, explaining why this hasn't
caused problems earlier.
Fixes <rdar://problem/15155975>.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@193535 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/MC')
| -rw-r--r-- | test/MC/ARM/basic-thumb2-instructions.s | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/MC/ARM/basic-thumb2-instructions.s b/test/MC/ARM/basic-thumb2-instructions.s index fdb22252ab..1954ba8299 100644 --- a/test/MC/ARM/basic-thumb2-instructions.s +++ b/test/MC/ARM/basic-thumb2-instructions.s @@ -226,12 +226,12 @@ _func: beq.w _bar bmi.w #-183396 -@ CHECK: b.w _bar @ encoding: [A,0xf0'A',A,0xb8'A'] +@ CHECK: b.w _bar @ encoding: [A,0xf0'A',A,0x90'A'] @ fixup A - offset: 0, value: _bar, kind: fixup_t2_uncondbranch @ CHECK: beq.w _bar @ encoding: [A,0xf0'A',A,0x80'A'] @ fixup A - offset: 0, value: _bar, kind: fixup_t2_condbranch @ CHECK: it eq @ encoding: [0x08,0xbf] -@ CHECK: beq.w _bar @ encoding: [A,0xf0'A',A,0xb8'A'] +@ CHECK: beq.w _bar @ encoding: [A,0xf0'A',A,0x90'A'] @ fixup A - offset: 0, value: _bar, kind: fixup_t2_uncondbranch @ CHECK: bmi.w #-183396 @ encoding: [0x13,0xf5,0xce,0xa9] |