diff options
| author | Chandler Carruth <chandlerc@gmail.com> | 2013-11-19 09:03:18 +0000 |
|---|---|---|
| committer | Chandler Carruth <chandlerc@gmail.com> | 2013-11-19 09:03:18 +0000 |
| commit | ed1951e79fb1a39c6308c4af9fb1539d0229df97 (patch) | |
| tree | f054b4b1731b5eb036c10696a645a051bcf8df65 /test/Transforms/SROA | |
| parent | 1b3ab9199f4f924eb610d984db9d1a722147f823 (diff) | |
| download | llvm-ed1951e79fb1a39c6308c4af9fb1539d0229df97.tar.gz llvm-ed1951e79fb1a39c6308c4af9fb1539d0229df97.tar.bz2 llvm-ed1951e79fb1a39c6308c4af9fb1539d0229df97.tar.xz | |
Fix an issue where SROA computed different results based on the relative
order of slices of the alloca which have exactly the same size and other
properties. This was found by a perniciously unstable sort
implementation used to flush out buggy uses of the algorithm.
The fundamental idea is that findCommonType should return the best
common type it can find across all of the slices in the range. There
were two bugs here previously:
1) We would accept an integer type smaller than a byte-width multiple,
and if there were different bit-width integer types, we would accept
the first one. This caused an actual failure in the testcase updated
here when the sort order changed.
2) If we found a bad combination of types or a non-load, non-store use
before an integer typed load or store we would bail, but if we found
the integere typed load or store, we would use it. The correct
behavior is to always use an integer typed operation which covers the
partition if one exists.
While a clever debugging sort algorithm found problem #1 in our existing
test cases, I have no useful test case ideas for #2. I spotted in by
inspection when looking at this code.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195118 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/Transforms/SROA')
| -rw-r--r-- | test/Transforms/SROA/basictest.ll | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/test/Transforms/SROA/basictest.ll b/test/Transforms/SROA/basictest.ll index 458b0df3c8..5d3e4b5d8b 100644 --- a/test/Transforms/SROA/basictest.ll +++ b/test/Transforms/SROA/basictest.ll @@ -1181,7 +1181,6 @@ entry: store i1 %x, i1* %b.i1, align 8 %b.i8 = bitcast <{ i1 }>* %b to i8* %foo = load i8* %b.i8, align 1 -; CHECK-NEXT: {{.*}} = zext i1 %x to i8 ; CHECK-NEXT: %[[ext:.*]] = zext i1 %x to i8 ; CHECK-NEXT: store i8 %[[ext]], i8* %[[a]], align 8 ; CHECK-NEXT: {{.*}} = load i8* %[[a]], align 8 |