diff options
| author | David Majnemer <david.majnemer@gmail.com> | 2014-03-09 06:41:58 +0000 |
|---|---|---|
| committer | David Majnemer <david.majnemer@gmail.com> | 2014-03-09 06:41:58 +0000 |
| commit | 39a09d2b7cf3a547df4a92c91280d5dc3b02318f (patch) | |
| tree | 398fa17458e23c2fcf88028c94929e55e4a39cca /test/Verifier | |
| parent | 3e07f8a03d85956013cd9e9b100ac274f44f3f34 (diff) | |
| download | llvm-39a09d2b7cf3a547df4a92c91280d5dc3b02318f.tar.gz llvm-39a09d2b7cf3a547df4a92c91280d5dc3b02318f.tar.bz2 llvm-39a09d2b7cf3a547df4a92c91280d5dc3b02318f.tar.xz | |
IR: Change inalloca's grammar a bit
The grammar for LLVM IR is not well specified in any document but seems
to obey the following rules:
- Attributes which have parenthesized arguments are never preceded by
commas. This form of attribute is the only one which ever has
optional arguments. However, not all of these attributes support
optional arguments: 'thread_local' supports an optional argument but
'addrspace' does not. Interestingly, 'addrspace' is documented as
being a "qualifier". What constitutes a qualifier? I cannot find a
definition.
- Some attributes use a space between the keyword and the value.
Examples of this form are 'align' and 'section'. These are always
preceded by a comma.
- Otherwise, the attribute has no argument. These attributes do not
have a preceding comma.
Sometimes an attribute goes before the instruction, between the
instruction and it's type, or after it's type. 'atomicrmw' has
'volatile' between the instruction and the type while 'call' has 'tail'
preceding the instruction.
With all this in mind, it seems most consistent for 'inalloca' on an
'inalloca' instruction to occur before between the instruction and the
type. Unlike the current formulation, there would be no preceding
comma. The combination 'alloca inalloca' doesn't look particularly
appetizing, perhaps a better spelling of 'inalloca' is down the road.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203376 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/Verifier')
| -rwxr-xr-x | test/Verifier/inalloca-vararg.ll | 2 | ||||
| -rw-r--r-- | test/Verifier/inalloca2.ll | 8 |
2 files changed, 5 insertions, 5 deletions
diff --git a/test/Verifier/inalloca-vararg.ll b/test/Verifier/inalloca-vararg.ll index 8521ebce2d..5099fd1992 100755 --- a/test/Verifier/inalloca-vararg.ll +++ b/test/Verifier/inalloca-vararg.ll @@ -2,7 +2,7 @@ declare void @h(i32, ...) define void @i() { - %args = alloca i32, inalloca + %args = alloca inalloca i32 call void (i32, ...)* @h(i32 1, i32* inalloca %args, i32 3) ; CHECK: inalloca isn't on the last argument! ret void diff --git a/test/Verifier/inalloca2.ll b/test/Verifier/inalloca2.ll index e4e81be386..12a4549992 100644 --- a/test/Verifier/inalloca2.ll +++ b/test/Verifier/inalloca2.ll @@ -6,7 +6,7 @@ declare void @doit(i64* inalloca %a) define void @a() { entry: - %a = alloca [2 x i32], inalloca + %a = alloca inalloca [2 x i32] %b = bitcast [2 x i32]* %a to i64* call void @doit(i64* inalloca %b) ret void @@ -14,7 +14,7 @@ entry: define void @b() { entry: - %a = alloca i64, inalloca + %a = alloca inalloca i64 call void @doit(i64* inalloca %a) call void @doit(i64* inalloca %a) ret void @@ -25,11 +25,11 @@ entry: br i1 %cond, label %if, label %else if: - %a = alloca i64, inalloca + %a = alloca inalloca i64 br label %call else: - %b = alloca i64, inalloca + %b = alloca inalloca i64 br label %call call: |