diff options
| author | Reid Kleckner <reid@kleckner.net> | 2014-04-21 20:48:47 +0000 |
|---|---|---|
| committer | Reid Kleckner <reid@kleckner.net> | 2014-04-21 20:48:47 +0000 |
| commit | 0df9abbd63a6cb3767d3ddf3b6c2f8ea8a4f6f7e (patch) | |
| tree | 4aa9b671f14fb7940eded1c5db0ad6c20e7fa92e /test | |
| parent | 290ce1944c02ec81787b80dc2a41119de5d7e412 (diff) | |
| download | llvm-0df9abbd63a6cb3767d3ddf3b6c2f8ea8a4f6f7e.tar.gz llvm-0df9abbd63a6cb3767d3ddf3b6c2f8ea8a4f6f7e.tar.bz2 llvm-0df9abbd63a6cb3767d3ddf3b6c2f8ea8a4f6f7e.tar.xz | |
Fix PR7272 in -tailcallelim instead of the inliner
The -tailcallelim pass should be checking if byval or inalloca args can
be captured before marking calls as tail calls. This was the real root
cause of PR7272.
With a better fix in place, revert the inliner change from r105255. The
test case it introduced still passes and has been moved to
test/Transforms/Inline/byval-tail-call.ll.
Reviewers: chandlerc
Differential Revision: http://reviews.llvm.org/D3403
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206789 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test')
| -rw-r--r-- | test/Transforms/Inline/byval-tail-call.ll (renamed from test/Transforms/Inline/2010-05-31-ByvalTailcall.ll) | 21 | ||||
| -rw-r--r-- | test/Transforms/TailCallElim/basic.ll | 8 |
2 files changed, 25 insertions, 4 deletions
diff --git a/test/Transforms/Inline/2010-05-31-ByvalTailcall.ll b/test/Transforms/Inline/byval-tail-call.ll index 07ea5fc6cc..3a8906aa21 100644 --- a/test/Transforms/Inline/2010-05-31-ByvalTailcall.ll +++ b/test/Transforms/Inline/byval-tail-call.ll @@ -1,10 +1,8 @@ ; RUN: opt < %s -tailcallelim -inline -instcombine -dse -S | FileCheck %s ; PR7272 -; When inlining through a byval call site, the inliner creates allocas which may -; be used by inlined calls, so any inlined calls need to have their 'tail' flags -; cleared. If not then you can get nastiness like with this testcase, where the -; (inlined) call to 'ext' in 'foo' was being passed an uninitialized value. +; Calls that capture byval parameters cannot be marked as tail calls. Other +; tails that don't capture byval parameters can still be tail calls. target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:32:32-n8:16:32" target triple = "i386-pc-linux-gnu" @@ -23,3 +21,18 @@ define void @foo(i32* %x) { call void @bar(i32* byval %x) ret void } + +define internal void @qux(i32* byval %x) { + call void @ext(i32* %x) + tail call void @ext(i32* null) + ret void +} +define void @frob(i32* %x) { +; CHECK-LABEL: define void @frob( +; CHECK: alloca i32 +; CHECK: {{^ *}}call void @ext( +; CHECK: tail call void @ext(i32* null) +; CHECK: ret void + tail call void @qux(i32* byval %x) + ret void +} diff --git a/test/Transforms/TailCallElim/basic.ll b/test/Transforms/TailCallElim/basic.ll index 35420ab08c..5582ee33ed 100644 --- a/test/Transforms/TailCallElim/basic.ll +++ b/test/Transforms/TailCallElim/basic.ll @@ -143,3 +143,11 @@ cond_false: call void @noarg() ret i32* null } + +; Don't tail call if a byval arg is captured. +define void @test9(i32* byval %a) { +; CHECK-LABEL: define void @test9( +; CHECK: {{^ *}}call void @use( + call void @use(i32* %a) + ret void +} |