diff options
| author | David Peixotto <dpeixott@codeaurora.org> | 2014-02-04 17:22:40 +0000 |
|---|---|---|
| committer | David Peixotto <dpeixott@codeaurora.org> | 2014-02-04 17:22:40 +0000 |
| commit | b92cca222898d87bbc764fa22e805adb04ef7f13 (patch) | |
| tree | f094e401b602d87e38489c8cb984437ce983fb4f /test | |
| parent | 7d9ed1cac54f5ed4274ae2735bd06e1017a83a9b (diff) | |
| download | llvm-b92cca222898d87bbc764fa22e805adb04ef7f13.tar.gz llvm-b92cca222898d87bbc764fa22e805adb04ef7f13.tar.bz2 llvm-b92cca222898d87bbc764fa22e805adb04ef7f13.tar.xz | |
Fix PR18345: ldr= pseudo instruction produces incorrect code when using in inline assembly
This patch fixes the ldr-pseudo implementation to work when used in
inline assembly. The fix is to move arm assembler constant pools
from the ARMAsmParser class to the ARMTargetStreamer class.
Previously we kept the assembler generated constant pools in the
ARMAsmParser object. This does not work for inline assembly because
a new parser object is created for each blob of inline assembly.
This patch moves the constant pools to the ARMTargetStreamer class
so that the constant pool will remain alive for the entire code
generation process.
An ARMTargetStreamer class is now required for the arm backend.
There was no existing implementation for MachO, only Asm and ELF.
Instead of creating an empty MachO subclass, we decided to make the
ARMTargetStreamer a non-abstract class and provide default
(llvm_unreachable) implementations for the non constant-pool related
methods.
Differential Revision: http://llvm-reviews.chandlerc.com/D2638
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200777 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test')
| -rw-r--r-- | test/CodeGen/ARM/inlineasm-ldr-pseudo.ll | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/test/CodeGen/ARM/inlineasm-ldr-pseudo.ll b/test/CodeGen/ARM/inlineasm-ldr-pseudo.ll new file mode 100644 index 0000000000..f63e4b0b3a --- /dev/null +++ b/test/CodeGen/ARM/inlineasm-ldr-pseudo.ll @@ -0,0 +1,17 @@ +; PR18354 +; We actually need to use -filetype=obj in this test because if we output +; assembly, the current code path will bypass the parser and just write the +; raw text out to the Streamer. We need to actually parse the inlineasm to +; demonstrate the bug. Going the asm->obj route does not show the issue. +; RUN: llc -mtriple=arm-none-linux < %s -filetype=obj | llvm-objdump -d - | FileCheck %s +; RUN: llc -mtriple=arm-apple-darwin < %s -filetype=obj | llvm-objdump -d - | FileCheck %s +; CHECK-LABEL: foo: +; CHECK: 0: 00 00 9f e5 ldr r0, [pc] +; CHECK: 4: 0e f0 a0 e1 mov pc, lr +; Make sure the constant pool entry comes after the return +; CHECK: 8: 01 00 00 00 +define i32 @foo() nounwind { +entry: + %0 = tail call i32 asm sideeffect "ldr $0,=1", "=r"() nounwind + ret i32 %0 +} |