diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2014-01-30 02:49:50 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2014-01-30 02:49:50 +0000 |
| commit | efdbec8b0a49fb67c3844be703548fdc6c1dded0 (patch) | |
| tree | 040894fc0c18d09dfdfec8693a253bcf998cb8c5 /tools/llvm-ar | |
| parent | 6bf3966f7fd92217360877d1c04ea8ffe47c11cc (diff) | |
| download | llvm-efdbec8b0a49fb67c3844be703548fdc6c1dded0.tar.gz llvm-efdbec8b0a49fb67c3844be703548fdc6c1dded0.tar.bz2 llvm-efdbec8b0a49fb67c3844be703548fdc6c1dded0.tar.xz | |
Simplify the handling of iterators in ObjectFile.
None of the object file formats reported error on iterator increment. In
retrospect, that is not too surprising: no object format stores symbols or
sections in a linked list or other structure that requires chasing pointers.
As a consequence, all error checking can be done on begin() and end().
This reduces the text segment of bin/llvm-readobj in my machine from 521233 to
518526 bytes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200442 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'tools/llvm-ar')
| -rw-r--r-- | tools/llvm-ar/llvm-ar.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/tools/llvm-ar/llvm-ar.cpp b/tools/llvm-ar/llvm-ar.cpp index 8917cd3801..bb5c0da8a3 100644 --- a/tools/llvm-ar/llvm-ar.cpp +++ b/tools/llvm-ar/llvm-ar.cpp @@ -716,10 +716,9 @@ static void writeSymbolTable( print32BE(Out, 0); } - error_code Err; for (object::symbol_iterator I = Obj->begin_symbols(), E = Obj->end_symbols(); - I != E; I.increment(Err), failIfError(Err)) { + I != E; ++I) { uint32_t Symflags; failIfError(I->getFlags(Symflags)); if (Symflags & object::SymbolRef::SF_FormatSpecific) |