diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2014-06-23 22:00:37 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2014-06-23 22:00:37 +0000 |
| commit | b138caba43b5c1a370bc9cf52d815c44bdf90159 (patch) | |
| tree | 319bb84424a6ab56954abb3a004a2bf8c1b18b6b /tools/llvm-objdump | |
| parent | 20732d55c2fda872a32b2335febafa7327f8b066 (diff) | |
| download | llvm-b138caba43b5c1a370bc9cf52d815c44bdf90159.tar.gz llvm-b138caba43b5c1a370bc9cf52d815c44bdf90159.tar.bz2 llvm-b138caba43b5c1a370bc9cf52d815c44bdf90159.tar.xz | |
Pass a std::unique_ptr& to the create??? methods is lib/Object.
This makes the buffer ownership on error conditions very natural. The buffer
is only moved out of the argument if an object is constructed that now
owns the buffer.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@211546 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'tools/llvm-objdump')
| -rw-r--r-- | tools/llvm-objdump/MachODump.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/llvm-objdump/MachODump.cpp b/tools/llvm-objdump/MachODump.cpp index 21c4c96d4c..74fdfef67c 100644 --- a/tools/llvm-objdump/MachODump.cpp +++ b/tools/llvm-objdump/MachODump.cpp @@ -203,7 +203,7 @@ void llvm::DisassembleInputMachO(StringRef Filename) { } std::unique_ptr<MachOObjectFile> MachOOF(static_cast<MachOObjectFile *>( - ObjectFile::createMachOObjectFile(Buff.release()).get())); + ObjectFile::createMachOObjectFile(Buff).get())); DisassembleInputMachO2(Filename, MachOOF.get()); } @@ -293,7 +293,7 @@ static void DisassembleInputMachO2(StringRef Filename, errs() << "llvm-objdump: " << Filename << ": " << ec.message() << '\n'; return; } - DbgObj = ObjectFile::createMachOObjectFile(Buf.release()).get(); + DbgObj = ObjectFile::createMachOObjectFile(Buf).get(); } // Setup the DIContext |