diff options
| author | Alexey Samsonov <samsonov@google.com> | 2013-11-18 09:31:53 +0000 |
|---|---|---|
| committer | Alexey Samsonov <samsonov@google.com> | 2013-11-18 09:31:53 +0000 |
| commit | b21ab43cfc3fa0dacf5c95f04e58b6d804b59a16 (patch) | |
| tree | 12f522231a5b3a875b1ac733a5bf1b1025088c7c /unittests/ADT/IntrusiveRefCntPtrTest.cpp | |
| parent | 69b2447b6a3fcc303e03cba8c7c50d745b0284d2 (diff) | |
| download | llvm-b21ab43cfc3fa0dacf5c95f04e58b6d804b59a16.tar.gz llvm-b21ab43cfc3fa0dacf5c95f04e58b6d804b59a16.tar.bz2 llvm-b21ab43cfc3fa0dacf5c95f04e58b6d804b59a16.tar.xz | |
Revert r194865 and r194874.
This change is incorrect. If you delete virtual destructor of both a base class
and a subclass, then the following code:
Base *foo = new Child();
delete foo;
will not cause the destructor for members of Child class. As a result, I observe
plently of memory leaks. Notable examples I investigated are:
ObjectBuffer and ObjectBufferStream, AttributeImpl and StringSAttributeImpl.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@194997 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'unittests/ADT/IntrusiveRefCntPtrTest.cpp')
| -rw-r--r-- | unittests/ADT/IntrusiveRefCntPtrTest.cpp | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/unittests/ADT/IntrusiveRefCntPtrTest.cpp b/unittests/ADT/IntrusiveRefCntPtrTest.cpp index 2be5aaf736..0c8c4ca16d 100644 --- a/unittests/ADT/IntrusiveRefCntPtrTest.cpp +++ b/unittests/ADT/IntrusiveRefCntPtrTest.cpp @@ -13,11 +13,9 @@ namespace llvm { struct VirtualRefCounted : public RefCountedBaseVPTR { - virtual void f(); + virtual void f() {} }; -void VirtualRefCounted::f() {} - // Run this test with valgrind to detect memory leaks. TEST(IntrusiveRefCntPtr, RefCountedBaseVPTRCopyDoesNotLeak) { VirtualRefCounted *V1 = new VirtualRefCounted; |