diff options
author | Reid Kleckner <reid@kleckner.net> | 2013-08-07 01:22:04 +0000 |
---|---|---|
committer | Reid Kleckner <reid@kleckner.net> | 2013-08-07 01:22:04 +0000 |
commit | 97c57dfcb4c76ede59443fe4c03e415ee7fa358a (patch) | |
tree | 24961b66454a2646411db87f8e10fe8d4a8a8ce8 /unittests/Support | |
parent | e3c7bdf9a955dac6536588f8ee9c25716f479a04 (diff) | |
download | llvm-97c57dfcb4c76ede59443fe4c03e415ee7fa358a.tar.gz llvm-97c57dfcb4c76ede59443fe4c03e415ee7fa358a.tar.bz2 llvm-97c57dfcb4c76ede59443fe4c03e415ee7fa358a.tar.xz |
Fix boolean logic in LockFileManager and test it
This fixes a bug from r187826.
Reviewers: hans
Differential Revision: http://llvm-reviews.chandlerc.com/D1304
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@187846 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'unittests/Support')
-rw-r--r-- | unittests/Support/CMakeLists.txt | 1 | ||||
-rw-r--r-- | unittests/Support/LockFileManagerTest.cpp | 48 |
2 files changed, 49 insertions, 0 deletions
diff --git a/unittests/Support/CMakeLists.txt b/unittests/Support/CMakeLists.txt index 5f26d5d745..197561ebaa 100644 --- a/unittests/Support/CMakeLists.txt +++ b/unittests/Support/CMakeLists.txt @@ -20,6 +20,7 @@ add_llvm_unittest(SupportTests IntegersSubsetTest.cpp LeakDetectorTest.cpp LocaleTest.cpp + LockFileManagerTest.cpp ManagedStatic.cpp MathExtrasTest.cpp MD5Test.cpp diff --git a/unittests/Support/LockFileManagerTest.cpp b/unittests/Support/LockFileManagerTest.cpp new file mode 100644 index 0000000000..5c73b9f5e2 --- /dev/null +++ b/unittests/Support/LockFileManagerTest.cpp @@ -0,0 +1,48 @@ +//===- unittests/LockFileManagerTest.cpp - LockFileManager tests ----------===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +#include "llvm/Support/LockFileManager.h" +#include "llvm/Support/FileSystem.h" +#include "llvm/Support/Path.h" + +#include "gtest/gtest.h" + +#include <memory> + +using namespace llvm; + +namespace { + +TEST(LockFileManagerTest, Basic) { + SmallString<64> TmpDir; + error_code EC; + EC = sys::fs::createUniqueDirectory("LockFileManagerTestDir", TmpDir); + ASSERT_FALSE(EC); + + SmallString<64> LockedFile(TmpDir); + sys::path::append(LockedFile, "file.lock"); + + { + // The lock file should not exist, so we should successfully acquire it. + LockFileManager Locked1(LockedFile); + EXPECT_EQ(LockFileManager::LFS_Owned, Locked1.getState()); + + // Attempting to reacquire the lock should fail. Waiting on it would cause + // deadlock, so don't try that. + LockFileManager Locked2(LockedFile); + EXPECT_NE(LockFileManager::LFS_Owned, Locked2.getState()); + } + + // Now that the lock is out of scope, the file should be gone. + EXPECT_FALSE(sys::fs::exists(StringRef(LockedFile))); + + sys::fs::remove_all(StringRef(TmpDir)); +} + +} // end anonymous namespace |