diff options
author | Rafael Espindola <rafael.espindola@gmail.com> | 2014-02-23 13:56:14 +0000 |
---|---|---|
committer | Rafael Espindola <rafael.espindola@gmail.com> | 2014-02-23 13:56:14 +0000 |
commit | 589d6377251d39e5f4d866bcb495bf6e547b4372 (patch) | |
tree | ecfc6cb9f76c144d99f1389ca266ecff177af386 /unittests/Transforms/DebugIR/DebugIR.cpp | |
parent | e4e42f7ff8c99fafeec556ee4b4d685b5896e9c8 (diff) | |
download | llvm-589d6377251d39e5f4d866bcb495bf6e547b4372.tar.gz llvm-589d6377251d39e5f4d866bcb495bf6e547b4372.tar.bz2 llvm-589d6377251d39e5f4d866bcb495bf6e547b4372.tar.xz |
Simplify remove, create_directory and create_directories.
Before this patch they would take an boolean argument to say if the path
already existed. This was redundant with the returned error_code which is able
to represent that. This allowed for callers to incorrectly check only the
existed flag instead of first checking the error code.
Instead, pass in a boolean flag to say if the previous (non-)existence should be
an error or not.
Callers of the of the old simple versions are not affected. They still ignore
the previous (non-)existence as they did before.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@201979 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'unittests/Transforms/DebugIR/DebugIR.cpp')
-rw-r--r-- | unittests/Transforms/DebugIR/DebugIR.cpp | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/unittests/Transforms/DebugIR/DebugIR.cpp b/unittests/Transforms/DebugIR/DebugIR.cpp index a0916a21d2..affdd762ba 100644 --- a/unittests/Transforms/DebugIR/DebugIR.cpp +++ b/unittests/Transforms/DebugIR/DebugIR.cpp @@ -55,9 +55,10 @@ void insertCUDescriptor(Module *M, StringRef File, StringRef Dir, /// Attempts to remove file at Path and returns true if it existed, or false if /// it did not. bool removeIfExists(StringRef Path) { - bool existed = false; - sys::fs::remove(Path, existed); - return existed; + // This is an approximation, on error we don't know in general if the file + // existed or not. + llvm::error_code EC = sys::fs::remove(Path, false); + return EC != llvm::errc::no_such_file_or_directory; } char * current_dir() { |