diff options
author | Rafael Espindola <rafael.espindola@gmail.com> | 2013-10-16 18:26:16 +0000 |
---|---|---|
committer | Rafael Espindola <rafael.espindola@gmail.com> | 2013-10-16 18:26:16 +0000 |
commit | 49978e61250a7229ad1040b002a609858f158584 (patch) | |
tree | 7dd3b8091d247aa545a73e16fcc6f22b7d559a00 /unittests | |
parent | 2906b519d1f47f1b269ed1be9c70f752b3dca928 (diff) | |
download | llvm-49978e61250a7229ad1040b002a609858f158584.tar.gz llvm-49978e61250a7229ad1040b002a609858f158584.tar.bz2 llvm-49978e61250a7229ad1040b002a609858f158584.tar.xz |
Fix MCDataAtom never calling remap when adding data.
This patch fixes a small mistake in MCDataAtom::addData() where it doesn't ever
call remap():
- if (Data.size() > Begin - End - 1)
+ if (Data.size() > End + 1 - Begin)
remap(Begin, End + 1);
This is currently not visible because of another bug is the disassembler, so
the patch includes a unit test.
Patch by Stephen Checkoway.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@192823 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'unittests')
-rw-r--r-- | unittests/CMakeLists.txt | 1 | ||||
-rw-r--r-- | unittests/MC/CMakeLists.txt | 11 | ||||
-rw-r--r-- | unittests/MC/MCAtomTest.cpp | 31 | ||||
-rw-r--r-- | unittests/MC/Makefile | 15 | ||||
-rw-r--r-- | unittests/Makefile | 2 |
5 files changed, 59 insertions, 1 deletions
diff --git a/unittests/CMakeLists.txt b/unittests/CMakeLists.txt index 3bfe9c0aff..52702ba23a 100644 --- a/unittests/CMakeLists.txt +++ b/unittests/CMakeLists.txt @@ -12,6 +12,7 @@ add_subdirectory(CodeGen) add_subdirectory(DebugInfo) add_subdirectory(ExecutionEngine) add_subdirectory(IR) +add_subdirectory(MC) add_subdirectory(Object) add_subdirectory(Option) add_subdirectory(Support) diff --git a/unittests/MC/CMakeLists.txt b/unittests/MC/CMakeLists.txt new file mode 100644 index 0000000000..0e4782c83f --- /dev/null +++ b/unittests/MC/CMakeLists.txt @@ -0,0 +1,11 @@ +set(LLVM_LINK_COMPONENTS + MC + ) + +set(MCSources + MCAtomTest.cpp + ) + +add_llvm_unittest(MCTests + ${MCSources} + ) diff --git a/unittests/MC/MCAtomTest.cpp b/unittests/MC/MCAtomTest.cpp new file mode 100644 index 0000000000..17b056cd2d --- /dev/null +++ b/unittests/MC/MCAtomTest.cpp @@ -0,0 +1,31 @@ +//===- llvm/unittest/MC/MCAtomTest.cpp - Instructions unit tests ----------===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +#include "llvm/MC/MCAtom.h" +#include "llvm/MC/MCModule.h" +#include "gtest/gtest.h" + +namespace llvm { +namespace { + +TEST(MCAtomTest, MCDataSize) { + MCModule M; + MCDataAtom *Atom = M.createDataAtom(0, 0); + EXPECT_EQ(uint64_t(0), Atom->getEndAddr()); + Atom->addData(0); + EXPECT_EQ(uint64_t(0), Atom->getEndAddr()); + Atom->addData(1); + EXPECT_EQ(uint64_t(1), Atom->getEndAddr()); + Atom->addData(2); + EXPECT_EQ(uint64_t(2), Atom->getEndAddr()); + EXPECT_EQ(size_t(3), Atom->getData().size()); +} + +} // end anonymous namespace +} // end namespace llvm diff --git a/unittests/MC/Makefile b/unittests/MC/Makefile new file mode 100644 index 0000000000..4c25697d28 --- /dev/null +++ b/unittests/MC/Makefile @@ -0,0 +1,15 @@ +##===- unittests/IR/Makefile -------------------------------*- Makefile -*-===## +# +# The LLVM Compiler Infrastructure +# +# This file is distributed under the University of Illinois Open Source +# License. See LICENSE.TXT for details. +# +##===----------------------------------------------------------------------===## + +LEVEL = ../.. +TESTNAME = MC +LINK_COMPONENTS := MC + +include $(LEVEL)/Makefile.config +include $(LLVM_SRC_ROOT)/unittests/Makefile.unittest diff --git a/unittests/Makefile b/unittests/Makefile index 4ba1179365..06ba93243e 100644 --- a/unittests/Makefile +++ b/unittests/Makefile @@ -10,7 +10,7 @@ LEVEL = .. PARALLEL_DIRS = ADT Analysis Bitcode CodeGen DebugInfo ExecutionEngine IR \ - Object Option Support Transforms + MC Object Option Support Transforms include $(LEVEL)/Makefile.common |