TableGen no longer emit CopyFromReg nodes for implicit results in physical

registers. The scheduler is now responsible for emitting them.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@41781 91177308-0d34-0410-b5e6-96231b3b80d8

1 files changed, 15 insertions, 44 deletions

diff --git a/utils/TableGen/DAGISelEmitter.cpp b/utils/TableGen/DAGISelEmitter.cpp
index 0fa3ba4c51..8f02438376 100644
--- a/utils/TableGen/DAGISelEmitter.cpp
+++ b/utils/TableGen/DAGISelEmitter.cpp
@@ -2768,8 +2768,8 @@ public:
         PatternHasProperty(Pattern, SDNPOptInFlag, ISE);
       bool NodeHasInFlag  = isRoot &&
         PatternHasProperty(Pattern, SDNPInFlag, ISE);
-      bool NodeHasOutFlag = HasImpResults || (isRoot &&
-        PatternHasProperty(Pattern, SDNPOutFlag, ISE));
+      bool NodeHasOutFlag = isRoot &&
+        PatternHasProperty(Pattern, SDNPOutFlag, ISE);
       bool NodeHasChain = InstPatNode &&
         PatternHasProperty(InstPatNode, SDNPHasChain, ISE);
       bool InputHasChain = isRoot &&
@@ -2869,7 +2869,7 @@ public:
 
       unsigned ResNo = TmpNo++;
       if (!isRoot || InputHasChain || NodeHasChain || NodeHasOutFlag ||
-          NodeHasOptInFlag) {
+          NodeHasOptInFlag || HasImpResults) {
         std::string Code;
         std::string Code2;
         std::string NodeName;
@@ -2895,6 +2895,18 @@ public:
           Code += ", VT" + utostr(VTNo);
           emitVT(getEnumName(N->getTypeNum(0)));
         }
+        // Add types for implicit results in physical registers, scheduler will
+        // care of adding copyfromreg nodes.
+        if (HasImpResults) {
+          for (unsigned i = 0, e = Inst.getNumImpResults(); i < e; i++) {
+            Record *RR = Inst.getImpResult(i);
+            if (RR->isSubClassOf("Register")) {
+              MVT::ValueType RVT = getRegisterValueType(RR, CGT);
+              Code += ", " + getEnumName(RVT);
+              ++NumResults;
+            }
+          }
+        }
         if (NodeHasChain)
           Code += ", MVT::Other";
         if (NodeHasOutFlag)
@@ -2999,11 +3011,6 @@ public:
                      utostr(NumResults + (unsigned)NodeHasChain) + ");");
         }
 
-        if (HasImpResults && EmitCopyFromRegs(N, ResNodeDecled, ChainEmitted)) {
-          emitCode("ReplaceUses(SDOperand(N.Val, 0), SDOperand(ResNode, 0));");
-          NumResults = 1;
-        }
-
         if (FoldedChains.size() > 0) {
           std::string Code;
           for (unsigned j = 0, e = FoldedChains.size(); j < e; j++)
@@ -3202,42 +3209,6 @@ private:
       emitCode("AddToISelQueue(InFlag);");
     }
   }
-
-  /// EmitCopyFromRegs - Emit code to copy result to physical registers
-  /// as specified by the instruction. It returns true if any copy is
-  /// emitted.
-  bool EmitCopyFromRegs(TreePatternNode *N, bool &ResNodeDecled,
-                        bool &ChainEmitted) {
-    bool RetVal = false;
-    Record *Op = N->getOperator();
-    if (Op->isSubClassOf("Instruction")) {
-      const DAGInstruction &Inst = ISE.getInstruction(Op);
-      const CodeGenTarget &CGT = ISE.getTargetInfo();
-      unsigned NumImpResults  = Inst.getNumImpResults();
-      for (unsigned i = 0; i < NumImpResults; i++) {
-        Record *RR = Inst.getImpResult(i);
-        if (RR->isSubClassOf("Register")) {
-          MVT::ValueType RVT = getRegisterValueType(RR, CGT);
-          if (RVT != MVT::Flag) {
-            if (!ChainEmitted) {
-              emitCode("SDOperand Chain = CurDAG->getEntryNode();");
-              ChainEmitted = true;
-              ChainName = "Chain";
-            }
-            std::string Decl = (!ResNodeDecled) ? "SDNode *" : "";
-            emitCode(Decl + "ResNode = CurDAG->getCopyFromReg(" + ChainName +
-                     ", " + ISE.getQualifiedName(RR) + ", " + getEnumName(RVT) +
-                     ", InFlag).Val;");
-            ResNodeDecled = true;
-            emitCode(ChainName + " = SDOperand(ResNode, 1);");
-            emitCode("InFlag = SDOperand(ResNode, 2);");
-            RetVal = true;
-          }
-        }
-      }
-    }
-    return RetVal;
-  }
 };
 
 /// EmitCodeForPattern - Given a pattern to match, emit code to the specified