diff options
| author | Arnold Schwaighofer <aschwaighofer@apple.com> | 2013-06-06 23:23:14 +0000 |
|---|---|---|
| committer | Arnold Schwaighofer <aschwaighofer@apple.com> | 2013-06-06 23:23:14 +0000 |
| commit | 45dc03287e29affeeb7e1f1281fca63d8b9773b1 (patch) | |
| tree | 35f1677ebd46e851c5ff7d640491307eedb2ce80 /utils | |
| parent | 81c5d11c25690cdb6282eb0ceb79f487325ce1e6 (diff) | |
| download | llvm-45dc03287e29affeeb7e1f1281fca63d8b9773b1.tar.gz llvm-45dc03287e29affeeb7e1f1281fca63d8b9773b1.tar.bz2 llvm-45dc03287e29affeeb7e1f1281fca63d8b9773b1.tar.xz | |
CodeGenSchedule: smallvector.push_back(smallvector[0]) is dangerous
The element passed to push_back is not copied before the vector reallocates.
The client needs to copy the element first before passing it to push_back.
No test case, will be tested by follow-up swift scheduler model change (it
segfaults without this change).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@183459 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'utils')
| -rw-r--r-- | utils/TableGen/CodeGenSchedule.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/utils/TableGen/CodeGenSchedule.cpp b/utils/TableGen/CodeGenSchedule.cpp index f2af7edbb2..53b72d03b5 100644 --- a/utils/TableGen/CodeGenSchedule.cpp +++ b/utils/TableGen/CodeGenSchedule.cpp @@ -1172,7 +1172,9 @@ pushVariant(const TransVariant &VInfo, bool IsRead) { unsigned OperIdx = RWSequences.size()-1; // Make N-1 copies of this transition's last sequence. for (unsigned i = 1, e = SelectedRWs.size(); i != e; ++i) { - RWSequences.push_back(RWSequences[OperIdx]); + // Create a temporary copy the vector could reallocate. + SmallVector<unsigned, 4> Tmp = RWSequences[OperIdx]; + RWSequences.push_back(Tmp); } // Push each of the N elements of the SelectedRWs onto a copy of the last // sequence (split the current operand into N operands). |