diff options
| -rw-r--r-- | lib/Analysis/ConstantFolding.cpp | 7 | ||||
| -rw-r--r-- | test/Transforms/InstCombine/fold-calls.ll | 5 |
2 files changed, 7 insertions, 5 deletions
diff --git a/lib/Analysis/ConstantFolding.cpp b/lib/Analysis/ConstantFolding.cpp index 96656a3c73..d3596d1c86 100644 --- a/lib/Analysis/ConstantFolding.cpp +++ b/lib/Analysis/ConstantFolding.cpp @@ -1094,6 +1094,13 @@ llvm::ConstantFoldCall(Function *F, if (!Ty->isFloatTy() && !Ty->isDoubleTy()) return 0; + + /// We only fold functions with finite arguments. Folding NaN and inf is + /// likely to be aborted with an exception anyway, and some host libms + /// have known errors raising exceptions. + if (Op->getValueAPF().isNaN() || Op->getValueAPF().isInfinity()) + return 0; + /// Currently APFloat versions of these functions do not exist, so we use /// the host native double versions. Float versions are not called /// directly but for all these it is true (float)(f((double)arg)) == diff --git a/test/Transforms/InstCombine/fold-calls.ll b/test/Transforms/InstCombine/fold-calls.ll index fbd09affcb..504f874bea 100644 --- a/test/Transforms/InstCombine/fold-calls.ll +++ b/test/Transforms/InstCombine/fold-calls.ll @@ -1,10 +1,5 @@ ; RUN: opt -instcombine -S < %s | FileCheck %s -; This test is inexplicably still failing, which suggests a bug in the host -; libm. It appears that sin(inf) returns NaN without setting a floating point -; exception. -; XFAIL: arm-pc-linux-gnu - ; This shouldn't fold, because sin(inf) is invalid. ; CHECK: @foo ; CHECK: %t = call double @sin(double 0x7FF0000000000000) |