summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWilliam Hubbs <w.d.hubbs@gmail.com>2013-10-18 16:26:46 -0500
committerWilliam Hubbs <w.d.hubbs@gmail.com>2013-10-18 16:32:51 -0500
commitd2988dc7ddd832ffc94f6b76c54898217812b7cc (patch)
tree0f92146b48b1309427b98f09615f965c30a1f7da
parent66970394ab3fa395685234a725eda0a4e48f43da (diff)
downloadopenrc-d2988dc7ddd832ffc94f6b76c54898217812b7cc.tar.gz
openrc-d2988dc7ddd832ffc94f6b76c54898217812b7cc.tar.bz2
openrc-d2988dc7ddd832ffc94f6b76c54898217812b7cc.tar.xz
remove redundant sync calls
The localmount and mount-ro scripts were flushing pending disk writes by calling sync twice in succession. This is no longer necessary; see the bug report and blog post for reasons we were still doing this. Reported-by: Patrick Lauer <patrick@gentoo.org> X-Gentoo-Bug: 487382 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=487382
-rw-r--r--init.d/localmount.in2
-rw-r--r--init.d/mount-ro.in2
2 files changed, 2 insertions, 2 deletions
diff --git a/init.d/localmount.in b/init.d/localmount.in
index 5444889..42b7988 100644
--- a/init.d/localmount.in
+++ b/init.d/localmount.in
@@ -59,7 +59,7 @@ stop()
no_umounts_r="^($no_umounts_r)$"
# Flush all pending disk writes now
- sync; sync
+ sync
. "$RC_LIBEXECDIR"/sh/rc-mount.sh
diff --git a/init.d/mount-ro.in b/init.d/mount-ro.in
index f8d7258..3e09352 100644
--- a/init.d/mount-ro.in
+++ b/init.d/mount-ro.in
@@ -15,7 +15,7 @@ start()
local ret=0
# Flush all pending disk writes now
- sync; sync
+ sync
ebegin "Remounting remaining filesystems read-only"
# We need the do_unmount function