diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2014-02-24 18:20:12 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2014-02-24 18:20:12 +0000 |
| commit | ac69459e0fe3df04788f5adcb94b1bec8b8cf8ad (patch) | |
| tree | 6260ace05d8d32042f39b42aead973d7c3ebaf9a /lib/Support/Windows | |
| parent | 137342f198093f68e112cd979782fae27bbb22ab (diff) | |
| download | llvm-ac69459e0fe3df04788f5adcb94b1bec8b8cf8ad.tar.gz llvm-ac69459e0fe3df04788f5adcb94b1bec8b8cf8ad.tar.bz2 llvm-ac69459e0fe3df04788f5adcb94b1bec8b8cf8ad.tar.xz | |
Replace the F_Binary flag with a F_Text one.
After this I will set the default back to F_None. The advantage is that
before this patch forgetting to set F_Binary would corrupt a file on windows.
Forgetting to set F_Text produces one that cannot be read in notepad, which
is a better failure mode :-)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202052 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Support/Windows')
| -rw-r--r-- | lib/Support/Windows/Path.inc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/Support/Windows/Path.inc b/lib/Support/Windows/Path.inc index a72d0bf0b1..98b2767c01 100644 --- a/lib/Support/Windows/Path.inc +++ b/lib/Support/Windows/Path.inc @@ -876,7 +876,7 @@ error_code openFileForWrite(const Twine &Name, int &ResultFD, if (Flags & F_Append) OpenFlags |= _O_APPEND; - if (!(Flags & F_Binary)) + if (Flags & F_Text) OpenFlags |= _O_TEXT; int FD = ::_open_osfhandle(intptr_t(H), OpenFlags); |